generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(bcm-pricing-calculator): Add Billing and Cost Management Pricing… #1486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Calculator workload estimate insights
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1486 +/- ##
==========================================
+ Coverage 89.46% 89.58% +0.12%
==========================================
Files 724 708 -16
Lines 50966 50161 -805
Branches 8145 8065 -80
==========================================
- Hits 45596 44938 -658
+ Misses 3459 3347 -112
+ Partials 1911 1876 -35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I have reviewed the missed code coverage lines and think those are expected. |
ehoxha91
reviewed
Oct 21, 2025
...-mcp-server/awslabs/billing_cost_management_mcp_server/tools/bcm_pricing_calculator_tools.py
Show resolved
Hide resolved
ehoxha91
approved these changes
Oct 21, 2025
chittev
previously approved these changes
Oct 21, 2025
chittev
approved these changes
Oct 27, 2025
krokoko
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Calculator workload estimate insights
Fixes
Summary
Changes
Testing
uv run --frozen pytest --cov --cov-branch --cov-report=term-missing. Found no regression in coverage. Unit tests pass. New code files are at 99% code coveragepre-commithookUser experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? N
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.